chore: improve error message for 'dfx cycles convert'.

[vincent-dfinity]

Description

If users run dfx cycles convert without enough ICP tokens, show additional messages to indicate what to do next.

Error: Failed to transfer funds.
Caused by: the debit account doesn't have enough funds to complete the transaction, current balance: 0.00000000 ICP
Caused by: Diagnosis was added here.
Error explanation:
Insufficient ICP balance to finish the transfer transaction.
How to resolve the error:
Please top up your ICP balance.

Your account address for receiving ICP from centralized exchanges: 8494c01329531c06254ff45dad87db806ae6ed935ad6a504cdbc00a935db7b49
(run `dfx ledger account-id` to display)

Your principal for ICP wallets and decentralized exchanges: ueuar-wxbnk-bdcsr-dnrh3-rsyq6-ffned-h64ox-vxywi-gzawf-ot4pv-sqe
(run `dfx identity get-principal` to display)

Actually, it's not just an issue with dfx cycles convert, if you call dfx ledger transfer you will hit the same error. So we fixed it at the ledger function call level.

Fixes # (issue)
SDK-1868

How Has This Been Tested?

A new e2e test added.

Checklist:

• The title of this PR complies with Conventional Commits.
• I have edited the CHANGELOG accordingly.
• I have made corresponding changes to the documentation.

[ericswanson-dfinity]

The linked ticket includes a recommendation for what messages to display. This includes displaying both the ledger account id and the identity's principal, in addition to the commands to display these. (note that neither of the listed commands has an option to generate a QR code, though).

[vincent-dfinity]

The linked ticket includes a recommendation for what messages to display. This includes displaying both the ledger account id and the identity's principal, in addition to the commands to display these. (note that neither of the listed commands has an option to generate a QR code, though).

Fixed at 1eacf6b.

[vincent-dfinity]

@sesi200 @ericswanson-dfinity For now the diagnosis error looks like pretty much as we expected

dfx cycles convert --amount=0.123 --ic
Error: Failed to transfer funds.
Caused by: the debit account doesn't have enough funds to complete the transaction, current balance: 0.00000000 ICP
Caused by: Diagnosis was added here.
Error explanation:
Insufficient ICP balance to finish the transfer transaction.
How to resolve the error:
Please top up your ICP balance.

Your account address for receiving ICP from centralized exchanges: 8494c01329531c06254ff45dad87db806ae6ed935ad6a504cdbc00a935db7b49
(run `dfx ledger account-id` to display)

Your principal for ICP wallets and decentralized exchanges:ueuar-wxbnk-bdcsr-dnrh3-rsyq6-ffned-h64ox-vxywi-gzawf-ot4pv-sqe
(run `dfx identity get-principal` to display)

The only problem is about Caused by: Diagnosis was added here., I cannot find a way to remove it.

Is it possible to remove #[error("Diagnosis was added here.")] as it won't help on figuring out anything from it?

[sesi200]

I think we should remove #[context("Diagnosis was added here")] as it's not helping.

The other option to removing it is to explicitly filter it out here, but then we'd just filter out the only use of that context error. Better remove it entirely

[vincent-dfinity]

I think we should remove #[context("Diagnosis was added here")] as it's not helping.

The other option to removing it is to explicitly filter it out here, but then we'd just filter out the only use of that context error. Better remove it entirely

Thanks. I've removed it at e9a127a. One thing is that it still inserts an empty error string, so I have to filter it out at where you pointed out.