Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve error message for 'dfx deploy'. #4018

Merged
merged 8 commits into from
Nov 27, 2024
Merged

chore: improve error message for 'dfx deploy'. #4018

merged 8 commits into from
Nov 27, 2024

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Nov 26, 2024 •
edited
Loading

Description

If users run dfx deploy without enough cycles, show additional messages to indicate what to do next.

Error explanation:
Insufficient cycles balance to create the canister.
How to resolve the error:
Please top up your cycles balance by converting ICP to cycles like below:
'dfx cycles convert --amount=0.123 --ic'.

Fixes # (issue)

SDK-1867

How Has This Been Tested?

Tested manually.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vincent-dfinity vincent-dfinity changed the title Improve error message for 'dfx deploy'. chore: improve error message for 'dfx deploy'. Nov 26, 2024
@vincent-dfinity vincent-dfinity marked this pull request as ready for review November 26, 2024 15:50
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner November 26, 2024 15:50
ericswanson-dfinity
ericswanson-dfinity requested changes Nov 26, 2024
View reviewed changes
src/dfx/src/lib/diagnosis.rs Outdated Show resolved Hide resolved
@vincent-dfinity vincent-dfinity merged commit 3405dc6 into master Nov 27, 2024
297 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/SDK-1867 branch November 27, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-dfinity @ericswanson-dfinity