fix: dfx deploy to the playground fails for a fresh project; CLI reads DFX_NETWORK #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Nov 14, 2024
ghost
pushed a commit
that referenced
this pull request
Nov 14, 2024
…s DFX_NETWORK (#3987) Fixes https://dfinity.atlassian.net/browse/SDK-1882 Fixes https://dfinity.atlassian.net/browse/SDK-1860 Fixes https://dfinity.atlassian.net/browse/SDK-1605 (cherry picked from commit ca58ec7)
ghost
pushed a commit
that referenced
this pull request
Nov 14, 2024
* chore: update motoko version * chore: update motoko version * chore: Release 0.24.2-beta.0 (#3961) Signed-off-by: Jason I <[email protected]> * fix: dfx deploy to the playground fails for a fresh project; CLI reads DFX_NETWORK (#3987) Fixes https://dfinity.atlassian.net/browse/SDK-1882 Fixes https://dfinity.atlassian.net/browse/SDK-1860 Fixes https://dfinity.atlassian.net/browse/SDK-1605 (cherry picked from commit ca58ec7) * chore: cherry pick ca58ec7 * chore: Release 0.24.2 (#3996) Signed-off-by: Jason <[email protected]> * chore: update manifest.json --------- Signed-off-by: Jason I <[email protected]> Signed-off-by: Jason <[email protected]> Co-authored-by: Eric Swanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
prebuildstep in all of the default projects isdfx generate. Since no--networkparameter was provided, the generate step happens for thelocalnetwork. When deploying withdfx deploy --playground, this would only work if at leastdfx build(to the local network) had been run previously.This PR makes all commands look for the
DFX_NETWORKparameter if no--networkparameter was passed.Fixes:
How Has This Been Tested?
Added an e2e test and tested manually.
Checklist: