Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update agent deps in frontend projects (alternate approach) #3975

Merged
merged 4 commits into from
Nov 7, 2024
Merged

chore: update agent deps in frontend projects (alternate approach) #3975

merged 4 commits into from
Nov 7, 2024

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Nov 6, 2024 •
edited
Loading

Alternative solution to #3974.

@rvanasa rvanasa requested a review from a team as a code owner November 6, 2024 23:42
@rvanasa rvanasa marked this pull request as draft November 6, 2024 23:42
@rvanasa rvanasa marked this pull request as ready for review November 7, 2024 00:41
dfx-json
dfx-json previously approved these changes Nov 7, 2024
View reviewed changes
@dfx-json dfx-json mentioned this pull request Nov 7, 2024
Closed
3 tasks
@chenyan-dfinity
Copy link
Contributor

Do we want to remove the package-lock.json file?

@rvanasa
Copy link
Contributor Author

rvanasa commented Nov 7, 2024 •
edited
Loading

Thanks for catching that; updated.

@dfx-json dfx-json merged commit 7d36bdd into master Nov 7, 2024
296 checks passed
@dfx-json dfx-json deleted the ryan/dfx-new-bump-agent-js branch November 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

@dfx-json dfx-json dfx-json left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvanasa @chenyan-dfinity @dfx-json