refactor: data-driven frontend, frontend test, and extra project templates #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
approved these changes
Sep 6, 2024
ericswanson-dfinity
deleted the
ens/sdk-1805-data-driven-frontend-and-extra-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the "frontend" and "extras" project templates to be data-driven rather than hardcoded. This is in preparation for extensions to be able to provide project templates.
Part of https://dfinity.atlassian.net/browse/SDK-1805
How Has This Been Tested?
Existing tests cover
dfx new(cli and interactive). I also tested the interactive flow manually.Added an e2e test that verifies that the project template options show up in the completion scripts.
Checklist: