Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recombine the install script #3564

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

ericswanson-dfinity
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity commented Feb 2, 2024

Description

This PR combines the individual files of the install script into a single file. Since it's easier to manage, this eliminates the need for a separate feature branch for the dfxvm install script. Instead, both install scripts are now stored as single files in public/.

Part of https://dfinity.atlassian.net/browse/SDK-758

How Has This Been Tested?

  • compared install-dfx.sh with output of curl -fsSL https://internetcomputer.org/install.sh. As expected, the only differences are the addition of comments.
  • compared install-dfxvm.sh with output of curl -fsSL https://raw.githubusercontent.com/dfinity/sdk/dfxvm-install-script/install.sh. As expected, the only differences are the addition of comments.
  • ran locally with sh -ci "$(cat install-dfx.sh)"
  • ran locally with sh -ci "$(cat install-dfxvm.sh)"

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity marked this pull request as ready for review February 2, 2024 20:00
@ericswanson-dfinity ericswanson-dfinity changed the title feat: rejoin the install script feat: recombine the install script Feb 2, 2024
@ericswanson-dfinity ericswanson-dfinity merged commit 8f84fda into master Feb 2, 2024
173 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/sdk-768-install-script-reunion branch February 2, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants