Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added query stats to canister status output #3551

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

Dfinity-skaestle
Copy link
Contributor

@Dfinity-skaestle Dfinity-skaestle commented Jan 30, 2024

Description

Display query stats when doing a canister status call via dfx.

How Has This Been Tested?

Ran against a dfx start deployed replica. All counters are reported as 0 as expected (since the query stats feature is currently disabled).

./dfx canister status canister_status_backend
Canister status call result for canister_status_backend.
Status: Running
Controllers: bnz7o-iuaaa-aaaaa-qaaaa-cai zp6ar-te3c2-c6t6s-5bhid-g4iax-2lsk5-7vuol-nk7qj-qbnie-znajy-iqe
Memory allocation: 0
Compute allocation: 0
Freezing threshold: 2_592_000
Memory Size: Nat(1936150)
Balance: 3_092_003_934_543 Cycles
Reserved: 0 Cycles
Reserved Cycles Limit: 5_000_000_000_000 Cycles
Module hash: 0x682631dae48a2628a6ed7ee01f022c33ddcfd75c1e1e1d8b218e4b877c7b11e4
Number of queries: 0
Instructions spent in queries: 0
Total query request paylod size (bytes): 0
Total query response payload size (bytes): 0

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@Dfinity-skaestle Dfinity-skaestle changed the title Added query stats to canister status output feat: Added query stats to canister status output Jan 30, 2024
@Dfinity-skaestle Dfinity-skaestle marked this pull request as ready for review January 30, 2024 13:30
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note to the "unreleased" section of https://github.com/dfinity/sdk/blob/master/CHANGELOG.md. Otherwise looks good.

@Dfinity-skaestle Dfinity-skaestle enabled auto-merge (squash) January 30, 2024 15:00
@Dfinity-skaestle Dfinity-skaestle merged commit d640d4a into master Jan 30, 2024
168 checks passed
@Dfinity-skaestle Dfinity-skaestle deleted the skaestle/query-stats-canister-status branch January 30, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants