Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create canister on specific subnets or subnet types #3527

Merged
merged 18 commits into from
Jan 25, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Jan 23, 2024

Description

dfx deploy, dfx canister create, and dfx ledger create-canister now support the option --subnet <subnet principal> to create canisters on specific subnets.
dfx canister create and dfx deploy now support the option --subnet-type <subnet type> to create canisters on a random subnet of a certain type.

Fixes SDK-1165

How Has This Been Tested?

Added e2e for dfx canister create and dfx deploy
Added test for --subnet for dfx ledger create-canister, --subnet-type is already covered

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 marked this pull request as ready for review January 23, 2024 13:02
@sesi200 sesi200 requested review from chenyan-dfinity and a team as code owners January 23, 2024 13:02
This reverts commit 2d9c108.
@sesi200 sesi200 merged commit 77cb8ae into master Jan 25, 2024
172 checks passed
@sesi200 sesi200 deleted the SDK-1165-deploy-canister-create-on-specific-subnet branch January 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants