-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create canister on specific subnets or subnet types #3527
Merged
sesi200
merged 18 commits into
master
from
SDK-1165-deploy-canister-create-on-specific-subnet
Jan 25, 2024
Merged
feat: create canister on specific subnets or subnet types #3527
sesi200
merged 18 commits into
master
from
SDK-1165-deploy-canister-create-on-specific-subnet
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Swanson <[email protected]>
ericswanson-dfinity
approved these changes
Jan 24, 2024
This reverts commit 2d9c108.
sesi200
deleted the
SDK-1165-deploy-canister-create-on-specific-subnet
branch
January 25, 2024 10:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx deploy
,dfx canister create
, anddfx ledger create-canister
now support the option--subnet <subnet principal>
to create canisters on specific subnets.dfx canister create
anddfx deploy
now support the option--subnet-type <subnet type>
to create canisters on a random subnet of a certain type.Fixes SDK-1165
How Has This Been Tested?
Added e2e for
dfx canister create
anddfx deploy
Added test for
--subnet
fordfx ledger create-canister
,--subnet-type
is already coveredChecklist: