feat: withdraw cycles to cycles ledger #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
approved these changes
Jan 16, 2024
sesi200
deleted the
SDK-1325-withdraw-cycles-from-deleted-canisters-to-cycles-ledger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a canister gets deleted, dfx withdraws as many cycles as possible to the cycles wallet. This PR adds the capability to withdraw to the cycles ledger instead when no wallet is configured.
No changelog entry because the feature flag will be disabled before merging
Fixes SDK-1325
How Has This Been Tested?
Added e2e
Checklist: