fix: nanosecond precision for playground canister acquisition timestamps #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econd precision SystemDateTime has OS-specific precision (100ns on Windows)
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
lwshang
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The playground backend returns acquisition timestamps with nanosecond precision, and uses nanosecond precision when looking up reserved canisters.
SystemDateTime has OS-specific precision. On Linux and OSX this is nanosecond precision, but on Windows it's 100ns precision. OffsetDateTime has nanosecond precision on all platforms.
The result was
dfx deploy --playgroundon Windows would return a "Canister not found" error from the playground backend.Part of https://dfinity.atlassian.net/browse/SDK-1343
How Has This Been Tested?
Covered by CI, and tested locally on OSX and Windows.
Checklist: