refactor: use const Principal for default faucet principal #3482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
DEFAULT_FAUCET_PRINCIPAL
fromconst &str
toconst Principal
for type safety and for consistency with other principal constants (seeMAINNET_BITCOIN_CANISTER_ID
,MAINNET_LEDGER_CANISTER_ID
, among others).Also removed the
allow_deprecated
flag sincePrincipal::from_slice
is no longer deprecated (to allow for this specific use case).How Has This Been Tested?
Added a test