-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update dfx cycles
commands with maninet cycles-ledger
canister ID
#3481
feat!: update dfx cycles
commands with maninet cycles-ledger
canister ID
#3481
Conversation
…th-default-cycles-ledger-canister-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably also require a change to assets/cycles-ledger/dfx.json and/or utils/cycles-ledger.bash in order to create the canister locally with the expected principal.
Co-authored-by: Eric Swanson <[email protected]>
@ericswanson-dfinity would the following approach suffice:
or should I deploy them separately from test's |
…th-default-cycles-ledger-canister-id
Yes, |
Co-authored-by: Eric Swanson <[email protected]>
dfx cycles
commands with maninet cycles-ledger
canister IDdfx cycles
commands with maninet cycles-ledger
canister ID
…th-default-cycles-ledger-canister-id
…th-default-cycles-ledger-canister-id
…th-default-cycles-ledger-canister-id
Description
The canister ID for
cycles-ledger
became known, therefore, it is no longer required to pass it as an CLI argument.How Has This Been Tested?
covered by CI
Checklist: