Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update dfx cycles commands with maninet cycles-ledger canister ID #3481

Conversation

smallstepman
Copy link
Contributor

Description

The canister ID for cycles-ledger became known, therefore, it is no longer required to pass it as an CLI argument.

How Has This Been Tested?

covered by CI

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@smallstepman smallstepman requested review from chenyan-dfinity and a team as code owners December 18, 2023 18:17
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably also require a change to assets/cycles-ledger/dfx.json and/or utils/cycles-ledger.bash in order to create the canister locally with the expected principal.

CHANGELOG.md Outdated Show resolved Hide resolved
src/dfx/src/lib/operations/cycles_ledger.rs Outdated Show resolved Hide resolved
Co-authored-by: Eric Swanson <[email protected]>
@smallstepman
Copy link
Contributor Author

@ericswanson-dfinity would the following approach suffice:

  assert_command dfx deploy cycles-ledger --specified-id "um5iw-rqaaa-aaaaq-qaaba-cai"
  assert_command dfx deploy cycles-depositor --argument "(record {ledger_id = principal \"$(dfx canister id cycles-ledger)\"})" --with-cycles 10000000000000 --specified-id "ul4oc-4iaaa-aaaaq-qaabq-cai"

or should I deploy them separately from test's dfx.json, and reference them as remote canisters?

@ericswanson-dfinity
Copy link
Member

@ericswanson-dfinity would the following approach suffice:

Yes, dfx deploy --specified-id is fine.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Swanson <[email protected]>
@smallstepman smallstepman changed the title chore: update dfx cycles commands with maninet cycles-ledger canister ID feat!: update dfx cycles commands with maninet cycles-ledger canister ID Dec 19, 2023
@smallstepman smallstepman enabled auto-merge (squash) December 19, 2023 21:03
@smallstepman smallstepman merged commit 4346ed7 into master Dec 22, 2023
172 checks passed
@smallstepman smallstepman deleted the mnl/SDK-1262-update-dfx-cycles-commands-with-default-cycles-ledger-canister-id branch December 22, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants