Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: domain configuration for icx-proxy #3471

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ericswanson-dfinity
Copy link
Member

Description

Add dfx.json, networks.json, and dfx start support for the icx-proxy --domain parameter.
Fixes https://dfinity.atlassian.net/browse/SDK-1327

How Has This Been Tested?

Added e2e tests and ran locally. The tests check that the parameter goes through, but don't check the functionality.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Sorry, something went wrong.

@ericswanson-dfinity ericswanson-dfinity marked this pull request as ready for review December 6, 2023 22:57
@bitdivine
Copy link
Member

Thank you!

@mergify mergify bot merged commit ee34ce9 into master Dec 7, 2023
179 checks passed
@mergify mergify bot deleted the ens/sdk-1327-icx-proxy-domain branch December 7, 2023 17:55
@mergify mergify bot removed the automerge-squash label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants