Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow hyphen in project names #3463

Closed
wants to merge 2 commits into from
Closed

feat: allow hyphen in project names #3463

wants to merge 2 commits into from

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Dec 4, 2023

Description

Fixes #3462

How Has This Been Tested?

adapted unit and e2e tests

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@chenyan-dfinity
Copy link
Contributor

I think this can break dfx generate for candid bindings, ab-cd is not a valid variable name for most languages.

@sesi200
Copy link
Contributor Author

sesi200 commented Dec 5, 2023

Will need more careful analysis in regards to the JS templating

@sesi200 sesi200 closed this Dec 5, 2023
@sesi200 sesi200 deleted the severin/project-name branch December 5, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dfx new not accepting names with dashes
2 participants
@sesi200 @chenyan-dfinity