feat: add cycles balance command #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
ericswanson-dfinity
changed the title
THLO
reviewed
Oct 10, 2023
| 89000000000000 cycles. | ||
| ``` | ||
|
|
||
| You can use the `dfx cycles balance` command to check the balance of another principal: |
There was a problem hiding this comment.
This functionality is actually not part of the design but it's a nice addition.
There was a problem hiding this comment.
dfx cycles balance: The function prints out the balance associated with the user’s principal ID by calling the icrc1_balance_of endpoint of the cycles ledger.
You are right, and I hadn't noticed that. I was looking at the arguments of icrc1_balance_of, which has an owner field, but the design doc doesn't require that dfx cycles balance passes anything other than the user's principal.
sesi200
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
dfx cycles balancesubcommand, hidden for the time being.Fixes https://dfinity.atlassian.net/browse/SDK-1160
How Has This Been Tested?
Added an e2e test and updated another to use
dfx cycles balancerather thandfx canister call.Checklist: