test: e2e test for cycles ledger #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
sesi200
approved these changes
Oct 9, 2023
smallstepman
pushed a commit
that referenced
this pull request
Nov 7, 2023
Adds an e2e test for the cycles ledger, using `dfx canister call`. Followup PRs that add new `dfx cycles` subcommands will replace some of those `dfx canister call` commands with those new commands, as well as add new tests that focus on those subcommands. Since the cycles-ledger repo is not yet public, this PR downloads its build artifacts from a temporary branch in this repo: https://github.com/dfinity/sdk/tree/cycles-ledger-prerelease Fixes https://dfinity.atlassian.net/browse/SDK-1170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an e2e test for the cycles ledger, using
dfx canister call. Followup PRs that add newdfx cyclessubcommands will replace some of thosedfx canister callcommands with those new commands, as well as add new tests that focus on those subcommands.Since the cycles-ledger repo is not yet public, this PR downloads its build artifacts from a temporary branch in this repo: https://github.com/dfinity/sdk/tree/cycles-ledger-prerelease
Fixes https://dfinity.atlassian.net/browse/SDK-1170
How Has This Been Tested?
Added an e2e test
Checklist: