Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for CI failures in playground e2e test #3394

Closed
wants to merge 4 commits into from

Conversation

ericswanson-dfinity
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity commented Sep 27, 2023

Description

A recent change to mops has added some logging output in CI. This makes its way to the moc command-line, which then fails.

		if (process.env.GITHUB_ENV) {
			console.log('Running in GitHub Actions, reducing threads to 4');
			threads = 4;
		}

See the first commit in this PR, which doesn't change anything that would matter, but fails due to passing this message along to moc:

"Running" "in" "GitHub" "Actions," "reducing" "threads" "to" "4" "--package" "base" ".mops/[email protected]/src" "--package" "splay" ".mops/[email protected]/src"' failed with exit status 'exit status: 1'.

The second commit in this PR filters the output of mops sources using grep, which demonstrates that the console.log() message is going to stdout.

How Has This Been Tested?

See above.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity marked this pull request as draft September 27, 2023 20:57
@ericswanson-dfinity
Copy link
Member Author

@ZenVoich can you make it so mops only outputs --package <path> to stdout, and anything else goes to stderr?

@ZenVoich
Copy link

@ericswanson-dfinity yes, removed extra console.log in mops 0.27.3

@ericswanson-dfinity ericswanson-dfinity deleted the mops-stdout branch May 6, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants