Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate builder.with_arg in wallet call #3372

Merged
merged 3 commits into from
Sep 19, 2023

changelog

db084f4
Select commit
Loading
Failed to load commit list.
Merged

fix: remove duplicate builder.with_arg in wallet call #3372

changelog
db084f4
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Mergify / Queue: Embarked in merge queue succeeded Sep 19, 2023 in 0s

The pull request embarked with master (20aeeb3) is mergeable

Required conditions for merge:

  • #approved-reviews-by>=1
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • base=master
  • branch-protection-review-decision=APPROVED [🛡 GitHub branch protection]
  • label=automerge-squash
  • status-success=audit:required
  • status-success=e2e:required
  • status-success=fmt:required
  • status-success=license-check:required
  • status-success=lint:required
  • status-success=prepare-dfx-assets:required
  • all of [📃 From pull request rule Automatic merge (squash)]:
    • #approved-reviews-by>=1
    • #changes-requested-reviews-by=0
    • -draft [:pushpin: queue requirement]
    • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
    • base=master
    • label=automerge-squash
    • status-success=audit:required
    • status-success=e2e:required
    • status-success=fmt:required
    • status-success=license-check:required
    • status-success=lint:required
    • status-success=prepare-dfx-assets:required
    • any of [:twisted_rightwards_arrows: queue conditions]:
      • all of [:pushpin: queue conditions of queue default]:
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • branch-protection-review-decision=APPROVED [🛡 GitHub branch protection]
        • any of [🛡 GitHub branch protection]:
          • check-success=lint:required
          • check-neutral=lint:required
          • check-skipped=lint:required
        • any of [🛡 GitHub branch protection]:
          • check-success=e2e:required
          • check-neutral=e2e:required
          • check-skipped=e2e:required
        • any of [🛡 GitHub branch protection]:
          • check-success=fmt:required
          • check-neutral=fmt:required
          • check-skipped=fmt:required
        • any of [🛡 GitHub branch protection]:
          • check-success=audit:required
          • check-neutral=audit:required
          • check-skipped=audit:required
        • any of [🛡 GitHub branch protection]:
          • check-success=prepare-dfx-assets:required
          • check-neutral=prepare-dfx-assets:required
          • check-skipped=prepare-dfx-assets:required
        • any of [🛡 GitHub branch protection]:
          • check-success=cla
          • check-neutral=cla
          • check-skipped=cla
        • any of [🛡 GitHub branch protection]:
          • check-success=license-check:required
          • check-neutral=license-check:required
          • check-skipped=license-check:required
  • any of [🛡 GitHub branch protection]:
    • check-success=lint:required
    • check-neutral=lint:required
    • check-skipped=lint:required
  • any of [🛡 GitHub branch protection]:
    • check-success=e2e:required
    • check-neutral=e2e:required
    • check-skipped=e2e:required
  • any of [🛡 GitHub branch protection]:
    • check-success=fmt:required
    • check-neutral=fmt:required
    • check-skipped=fmt:required
  • any of [🛡 GitHub branch protection]:
    • check-success=audit:required
    • check-neutral=audit:required
    • check-skipped=audit:required
  • any of [🛡 GitHub branch protection]:
    • check-success=prepare-dfx-assets:required
    • check-neutral=prepare-dfx-assets:required
    • check-skipped=prepare-dfx-assets:required
  • any of [🛡 GitHub branch protection]:
    • check-success=cla
    • check-neutral=cla
    • check-skipped=cla
  • any of [🛡 GitHub branch protection]:
    • check-success=license-check:required
    • check-neutral=license-check:required
    • check-skipped=license-check:required

Check-runs and statuses of the embarked pull request #3372:

publishdetails
audit (macos-latest, 0.17.4, 12719bd23b88573977c7ad7fe818b05e8fbc33b3)details
audit (ubuntu-latest, 0.17.4, 12719bd23b88573977c7ad7fe818b05e8fbc33b3)details
audit:requireddetails
build_dfx (macos-12)details
build_dfx (ubuntu-20.04)details
build_dfx (ubuntu-22.04)details
build_dfx (x86_64-apple-darwin)details
build_dfx (x86_64-unknown-linux-gnu)details
build_matrixdetails
checkdetails
claCLA review statusdetails
conventional-pr-title:requireddetails
e2e:requireddetails
fmt (ubuntu-latest)details
fmt:requireddetails
frontend-canister-up-to-date:requireddetails
license-check:requireddetails
lint (macos-latest)details
lint (ubuntu-latest)details
lint (windows-latest)details
lint:requireddetails
list_testsdetails
prepare (macos-latest)details
prepare (ubuntu-latest)details
prepare-dfx-assets:requireddetails
publishable:requireddetails
smoke (ic-ref, macos-12)details
smoke (ic-ref, ubuntu-20.04)details
smoke (ic-ref, ubuntu-22.04)details
smoke (replica, macos-12)details
smoke (replica, ubuntu-20.04)details
smoke (replica, ubuntu-22.04)details
test (dfx/assetscanister, replica, macos-12)details
test (dfx/assetscanister, replica, ubuntu-20.04)details
test (dfx/base, replica, macos-12)details
test (dfx/base, replica, ubuntu-20.04)details
test (dfx/basic-project, replica, macos-12)details
test (dfx/basic-project, replica, ubuntu-20.04)details
test (dfx/bitcoin, replica, macos-12)details
test (dfx/bitcoin, replica, ubuntu-20.04)details
test (dfx/bootstrap, replica, macos-12)details
test (dfx/bootstrap, replica, ubuntu-20.04)details
test (dfx/build, replica, macos-12)details
test (dfx/build, replica, ubuntu-20.04)details
test (dfx/build_granular, replica, macos-12)details
test (dfx/build_granular, replica, ubuntu-20.04)details
test (dfx/build_rust, replica, macos-12)details
test (dfx/build_rust, replica, ubuntu-20.04)details
test (dfx/call, replica, macos-12)details
test (dfx/call, replica, ubuntu-20.04)details
test (dfx/candid_ui, replica, macos-12)details
test (dfx/candid_ui, replica, ubuntu-20.04)details
test (dfx/canister_http, replica, macos-12)details
test (dfx/canister_http, replica, ubuntu-20.04)details
test (dfx/certificate, replica, macos-12)details
test (dfx/certificate, replica, ubuntu-20.04)details
test (dfx/certified_info, replica, macos-12)details
test (dfx/certified_info, replica, ubuntu-20.04)details
test (dfx/create, replica, macos-12)details
test (dfx/create, replica, ubuntu-20.04)details
test (dfx/delete, replica, macos-12)details
test (dfx/delete, replica, ubuntu-20.04)details
test (dfx/deploy, replica, macos-12)details
test (dfx/deploy, replica, ubuntu-20.04)details
test (dfx/deps, replica, macos-12)details
test (dfx/deps, replica, ubuntu-20.04)details
test (dfx/describe_local_network, replica, macos-12)details
test (dfx/describe_local_network, replica, ubuntu-20.04)details
test (dfx/dfx_install, replica, macos-12)details
test (dfx/dfx_install, replica, ubuntu-20.04)details
test (dfx/dotenv, replica, macos-12)details
test (dfx/dotenv, replica, ubuntu-20.04)details
test (dfx/ed25519, replica, macos-12)details
test (dfx/ed25519, replica, ubuntu-20.04)details
test (dfx/error_context, replica, macos-12)details
test (dfx/error_context, replica, ubuntu-20.04)details
test (dfx/error_diagnosis, replica, macos-12)details
test (dfx/error_diagnosis, replica, ubuntu-20.04)details
test (dfx/extension, replica, macos-12)details
test (dfx/extension, replica, ubuntu-20.04)details
test (dfx/fabricate_cycles, replica, macos-12)details
test (dfx/fabricate_cycles, replica, ubuntu-20.04)details
test (dfx/frontend, replica, macos-12)details
test (dfx/frontend, replica, ubuntu-20.04)details
test (dfx/generate, replica, macos-12)details
test (dfx/generate, replica, ubuntu-20.04)details
test (dfx/id, replica, macos-12)details
test (dfx/id, replica, ubuntu-20.04)details
test (dfx/identity, replica, macos-12)details
test (dfx/identity, replica, ubuntu-20.04)details
test (dfx/identity_command, replica, macos-12)details
test (dfx/identity_command, replica, ubuntu-20.04)details
test (dfx/identity_encryption, replica, macos-12)details
test (dfx/identity_encryption, replica, ubuntu-20.04)details
test (dfx/info, replica, macos-12)details
test (dfx/info, replica, ubuntu-20.04)details
test (dfx/install, replica, macos-12)details
test (dfx/install, replica, ubuntu-20.04)details
test (dfx/inter, replica, macos-12)details
test (dfx/inter, replica, ubuntu-20.04)details
test (dfx/leak, replica, macos-12)details
test (dfx/leak, replica, ubuntu-20.04)details
test (dfx/ledger, replica, macos-12)details
test (dfx/ledger, replica, ubuntu-20.04)details
test (dfx/metadata, replica, macos-12)details
test (dfx/metadata, replica, ubuntu-20.04)details
test (dfx/migrate, replica, macos-12)details
test (dfx/migrate, replica, ubuntu-20.04)details
test (dfx/mode_reinstall, replica, macos-12)details
test (dfx/mode_reinstall, replica, ubuntu-20.04)details
test (dfx/network, replica, macos-12)details
test (dfx/network, replica, ubuntu-20.04)details
test (dfx/new, replica, macos-12)details
test (dfx/new, replica, ubuntu-20.04)details
test (dfx/packtool, replica, macos-12)details
test (dfx/packtool, replica, ubuntu-20.04)details
test (dfx/ping, replica, macos-12)details
test (dfx/ping, replica, ubuntu-20.04)details
test (dfx/playground, replica, macos-12)details
test (dfx/playground, replica, ubuntu-20.04)details
test (dfx/print, replica, macos-12)details
test (dfx/print, replica, ubuntu-20.04)details
test (dfx/project_local_network, replica, macos-12)details
test (dfx/project_local_network, replica, ubuntu-20.04)details
test (dfx/provider, replica, macos-12)details
test (dfx/provider, replica, ubuntu-20.04)details
test (dfx/remote, replica, macos-12)details
test (dfx/remote, replica, ubuntu-20.04)details
test (dfx/remote_generate_binding, replica, macos-12)details
View more details on Mergify