chore: update deploy playground with new backend API #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Sep 15, 2023
|
|
||
| public shared ({ caller }) func getCanisterId(nonce : PoW.Nonce) : async Types.CanisterInfo { | ||
| public shared ({ caller }) func getCanisterId(nonce : PoW.Nonce, origin : Logs.Origin) : async Types.CanisterInfo { |
There was a problem hiding this comment.
Duplicating the whole playground backend here in the e2e/assets sure is a lot of technical debt. Can you think of a better way to maintain this?
There was a problem hiding this comment.
I agree. We can git clone motoko-playground repo and build, instead of hardcoding the code here. We only need to build the pool canister, and it's okay to keep the pre-built wasm-utils.wasm here. Would be good to do as a follow up PR.
There was a problem hiding this comment.
Follow-up PR sounds great. Thanks!
ericswanson-dfinity
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx deploy --playgroundwhen in CI environment.dfx. It's only used for monitoring purposes.Checklist: