Skip to content

Commit

Permalink
fix: on PRs, run shellcheck for install scripts (#3469)
Browse files Browse the repository at this point in the history
Runs the shellcheck workflow for the install script on PRs as well as merge to master, skipping the upload step for PRs.
For the publish-manifest workflow, sets the name to `install-script-shellcheck:required` for later inclusion as a required status.
Does not do this for the dfxvm-install-script-shellcheck, since we'd only remove it again soon, but it will still be reported as a status.
  • Loading branch information
ericswanson-dfinity authored Dec 6, 2023
1 parent 4b974c6 commit 4b36d59
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/publish-dfxvm-install-script.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- sdk-1278-dfxvm-install-script
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -17,6 +18,7 @@ env:

jobs:
publish-manifest:
name: dfxvm-install-script-shellcheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -37,6 +39,7 @@ jobs:
s/ *#.*//
" _out/install.sh
- name: Upload Artifacts
if: github.event_name == 'push'
uses: JamesIves/github-pages-deploy-action@releases/v3
with:
single_commit: yes
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish-manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -17,6 +18,7 @@ env:

jobs:
publish-manifest:
name: install-script-shellcheck:required
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -38,6 +40,7 @@ jobs:
" _out/install.sh
cp public/manifest.json _out/manifest.json
- name: Upload Artifacts
if: github.event_name == 'push'
uses: JamesIves/github-pages-deploy-action@releases/v3
with:
single_commit: yes
Expand Down

0 comments on commit 4b36d59

Please sign in to comment.