fix(extension): when executing ext, allow params with hyphens (#3231)

e2e/tests-dfx/extension.bash

@@ -115,3 +115,44 @@ echo testoutput' > "$CACHE_DIR"/extensions/test_extension/test_extension
     assert_match 'No extensions installed'
 }
 
+
+@test "run with hyphened parameters" {
+    CACHE_DIR=$(dfx cache show)
+    mkdir -p "$CACHE_DIR"/extensions/test_extension
+
+    cat > "$CACHE_DIR"/extensions/test_extension/test_extension << "EOF"
+#!/usr/bin/env bash
+
+if [ "$2" == "--the-param" ]; then
+    echo "pamparam the param is $3"
+fi
+EOF
+
+    chmod +x "$CACHE_DIR"/extensions/test_extension/test_extension
+
+    cat > "$CACHE_DIR"/extensions/test_extension/extension.json <<EOF
+{
+  "name": "test_extension",
+  "version": "0.1.0",
+  "homepage": "https://github.com/dfinity/dfx-extensions",
+  "authors": "DFINITY",
+  "summary": "Test extension for e2e purposes.",
+  "categories": [],
+  "keywords": [],
+  "subcommands": {
+    "abc": {
+      "about": "something something",
+      "args": {
+        "the_param": {
+          "about": "this is the param",
+          "long": "the-param"
+        }
+      }
+    }
+  }
+}
+EOF
+
+    assert_command dfx test_extension abc --the-param 123
+    assert_eq "pamparam the param is 123"
+}

src/dfx/src/commands/extension/run.rs

@@ -10,6 +10,7 @@ pub struct RunOpts {
     /// Specifies the name of the extension to run.
     name: OsString,
     /// Specifies the parameters to pass to the extension.
+    #[arg(allow_hyphen_values = true)]
     params: Vec<OsString>,
 }