reword

dfinity · Nov 1, 2023 · 10ee585 · 10ee585
1 parent ef226cd
commit 10ee585
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/e2e/tests-dfx/assetscanister.bash b/e2e/tests-dfx/assetscanister.bash
@@ -1235,8 +1235,6 @@ CHERRIES" "$stdout"
 
   touch src/e2e_project_frontend/assets/thing.json
 
-  # this test used to also set etag, but that breaks certification
-  # see https://dfinity.atlassian.net/browse/SDK-1245
   echo '[
     {
       "match": "thing.json",

diff --git a/src/canisters/frontend/ic-certified-assets/src/asset_certification/types/http.rs b/src/canisters/frontend/ic-certified-assets/src/asset_certification/types/http.rs
@@ -184,7 +184,7 @@ impl HttpResponse {
         } else {
             if !headers
                 .iter()
-                .any(|(header, _)| header.eq_ignore_ascii_case("etag"))
+                .any(|(header_name, _)| header_name.eq_ignore_ascii_case("etag"))
             {
                 headers.insert(
                     "etag".to_string(),

diff --git a/src/canisters/frontend/ic-certified-assets/src/tests.rs b/src/canisters/frontend/ic-certified-assets/src/tests.rs
@@ -1879,7 +1879,7 @@ mod certification_v2 {
     #[test]
     fn etag() {
         // For now only checks that defining a custom etag doesn't break certification.
-        // Serving 304 responses if the etag matches is part of https://dfinity.atlassian.net/browse/SDK-191
+        // Serving HTTP 304 responses if the etag matches is part of https://dfinity.atlassian.net/browse/SDK-191
 
         let mut state = State::default();
         let time_now = 100_000_000_000;