Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ic-http-certification): add http response convenience methods #398

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev commented Nov 28, 2024

Most changes are just using the new convenience methods, I've commented the main file were the meaningful changes are.

@nathanosdev nathanosdev requested a review from a team as a code owner November 28, 2024 17:33
Base automatically changed from nathan/request-method-enum to main December 3, 2024 15:38
przydatek
przydatek previously approved these changes Dec 9, 2024
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

przydatek
przydatek previously approved these changes Dec 9, 2024
@nathanosdev nathanosdev enabled auto-merge (squash) December 9, 2024 14:32
@nathanosdev nathanosdev merged commit 911afa6 into main Dec 9, 2024
6 checks passed
@nathanosdev nathanosdev deleted the nathan/add-response-convenience-methods branch December 9, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants