Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ic-asset-certification): integrate add_certificate_header into the library so consumers do not need to call it manually #369

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat(ic-asset-certification): integrate add_certificate_header into the library so consumers do not need to call it manually #369

merged 2 commits into from
Sep 19, 2024

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev self-assigned this Sep 17, 2024
@nathanosdev nathanosdev marked this pull request as ready for review September 17, 2024 09:00
@nathanosdev nathanosdev requested a review from a team as a code owner September 17, 2024 09:00
przydatek
przydatek reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the final shape of this PR depends on #360, but please see some initial comments/questions.

packages/ic-asset-certification/src/asset_router.rs Outdated Show resolved Hide resolved
packages/ic-asset-certification/src/asset_router.rs Outdated Show resolved Hide resolved
packages/ic-asset-certification/src/asset_router.rs Show resolved Hide resolved
Base automatically changed from nathan/encode-certificate-header to main September 18, 2024 13:42
@nathanosdev nathanosdev force-pushed the nathan/simplify-serve-asset branch from 0dd62e5 to bf7e937 Compare September 18, 2024 14:23
przydatek
przydatek approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nathanosdev nathanosdev merged commit 173afde into main Sep 19, 2024
6 checks passed
@nathanosdev nathanosdev deleted the nathan/simplify-serve-asset branch September 19, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przydatek przydatek przydatek approved these changes

Assignees

@nathanosdev nathanosdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanosdev @przydatek