Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cel builder to ic-http-certification crate #235

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: add cel builder to ic-http-certification crate #235

merged 1 commit into from
Nov 28, 2023

Conversation

nathanosdev
Copy link
Member

No description provided.

@nathanosdev nathanosdev self-assigned this Nov 27, 2023
@nathanosdev nathanosdev force-pushed the nathan/add-cel-builder branch 2 times, most recently from 080adcf to d90710d Compare November 27, 2023 20:27
Base automatically changed from nathan/add-cel-expression-generation to main November 27, 2023 22:29
@nathanosdev nathanosdev force-pushed the nathan/add-cel-builder branch from d90710d to 99c639d Compare November 27, 2023 23:06
@nathanosdev nathanosdev force-pushed the nathan/add-cel-builder branch from 99c639d to 8affb5f Compare November 28, 2023 10:08
@nathanosdev nathanosdev marked this pull request as ready for review November 28, 2023 10:32
@nathanosdev nathanosdev requested a review from a team as a code owner November 28, 2023 10:32
keplervital
keplervital approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/ic-http-certification/src/lib.rs Show resolved Hide resolved
@nathanosdev nathanosdev merged commit fe974c2 into main Nov 28, 2023
7 checks passed
@nathanosdev nathanosdev deleted the nathan/add-cel-builder branch November 28, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keplervital keplervital keplervital approved these changes

Assignees

@nathanosdev nathanosdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanosdev @keplervital