chore: migrate wasm crates to workspace #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanosdev
force-pushed
the
nathan/use-cargo-workspace-better
branch
from
bb9c58c to
31cefd7
Compare
nathanosdev
force-pushed
the
nathan/migrate-nested-rbtree-to-ic-certification
branch
from
2b4e67b to
fc89828
Compare
nathanosdev
force-pushed
the
nathan/use-cargo-workspace-better
branch
from
31cefd7 to
4cbcf31
Compare
Base automatically changed from
nathan/migrate-nested-rbtree-to-ic-certification
to
main
November 17, 2023 10:39
nathanosdev
commented
Nov 17, 2023
nathanosdev
force-pushed
the
nathan/use-cargo-workspace-better
branch
from
4cbcf31 to
7c923eb
Compare
nathanosdev
force-pushed
the
nathan/use-cargo-workspace-better
branch
from
7c923eb to
a77ce53
Compare
keplervital
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the crates to the root workspace.
There's a workaround for the WASM crates by using the
default-membersof the root workspace. It's not ideal, but while we wait for rust-lang/cargo#9406 I think this is a better situation. I'll also follow up with a root DFX workspace now, currently there's two separate ones and likely more to come as more examples are added for the certification libraries so it will be nice to have that too.