Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: textual description of ic0.msg_method_name_size and ic0.msg_method_name_copy #3908

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Dec 19, 2024

This PR adds a textual description of ic0.msg_method_name_size and ic0.msg_method_name_copy so that a textual description is available for all system API functions.

Thanks, @lwshang , for reporting!

@mraszyk mraszyk requested a review from a team as a code owner December 19, 2024 07:26
@github-actions github-actions bot added the interface-spec Changes to the IC Interface Specification label Dec 19, 2024
@mraszyk mraszyk requested a review from lwshang December 19, 2024 19:42
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lwshang and @mraszyk for resolving this!

@mraszyk mraszyk enabled auto-merge (squash) December 20, 2024 12:30
@mraszyk mraszyk merged commit 53b36d6 into master Dec 20, 2024
8 checks passed
@mraszyk mraszyk deleted the mraszyk/ic0-msg-method-name branch December 20, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface-spec Changes to the IC Interface Specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants