fix: Link HTTPS outcalls to the https outcalls overview page #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessiemongeon1
approved these changes
Dec 10, 2024
rsoury
added a commit
to usherlabs/portal
that referenced
this pull request
Dec 10, 2024
* 'master' of github.com:usherlabs/portal: fix: WSL install instructions (dfinity#3870) fix: http_request_update (dfinity#3868) fix: Link HTTPS outcalls to the https outcalls overview page (dfinity#3872) Update showcase.json (dfinity#3654) Remove overview headings (dfinity#3866) Add icptokens.net to showcase (dfinity#3751) add library to learn menu (dfinity#3867) add library page (dfinity#3864) Update ICRC ledger setup docs to point to the new GitHub releases (dfinity#3862) Update showcase.json fix: Cleanup docs (dfinity#3856) Dev weekly update December 4 2024 (dfinity#3855) lint: add link validation plugin (dfinity#3847) update discord link (dfinity#3857) update discord link (dfinity#3858) optimize images for showcase (dfinity#3853)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link points to the security section, seems like it would make more sense to point to the https outcalls overview.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdxfile format to support the previous two components./sidebars.js, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERSfile isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.