Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs best effort responses #3865
base: master
Are you sure you want to change the base?
Add docs best effort responses #3865
Changes from 6 commits
f61fe5a
5f89f7e
44806de
410e042
2916a32
0613d32
d344cd9
ddf5818
e213314
7d82156
d545ab8
0132c93
9eb0ce2
7f4f09b
d626bb4
7da5a43
dacf8bc
7a4f424
2cd1f77
bf6cb13
2ad10b6
f7f7e1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A trustworthy
C2
could also stall indefinitely because of an untrustworthyC3
, as per the above.Depends on the bug. If you mean a bug in the protocol, I would not mention it. A lot of things can happen due to bugs in the protocol.
If you mean a but in
C2
, then it could be an infinite retry (e.g.C2
mishandling a "canister not found" error), so not exactly "rather unlikely" (I guess it's not exactly likely either, but it's very much a risk worth considering).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
I would leave out "a bug in [...] its subnet", unless you mean "a temporarily stalled subnet".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point the proxy canister is a poor man's best-effort call. Which is I guess what it always was. I don't know whether it's still worth mentioning as an option.