-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logo requirements #3852
Update logo requirements #3852
Conversation
Update logo requirements, include recommendations for optimizing file size.
Could you elaborate on why you want to remove WebP? It’s actually the smallest format of the three. If anything, I’d consider removing PNG instead and adding a max file size (KB) requirement to ensure consistency. That said, keep in mind that not all tools export WebP natively, which might pose challenges for some contributors. Also, SVGs can be tricky since their size depends heavily on the complexity of the logo. |
My bad, didn't intend to remove webp, adding it back. Since it's regarding logos, in most cases SVG would be a smaller file size and also scale when used in various sizes. The raster file formats (png/webp) are there for the few logos that are too complex for a SVG. |
@sea-snake I would typically agree but we had a few cases where the SVGs were huge. My proposal would be: screenshots: jpeg / webP (specify the PX size and a max KB size maybe max 300?) |
I added recommended online tooling for file size optimizations in this PR that saves roughly 70% in most cases, compared to explicit file size limits this seems like a more proactive approach to enable users to keep file sizes optimal. |
@sea-snake I don't feel strongly about it. LGTM |
Update logo requirements, include recommendations for optimizing file size.
.mdx
file format to support the previous two components./sidebars.js
, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERS
file isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.