Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo requirements #3852

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

sea-snake
Copy link
Contributor

Update logo requirements, include recommendations for optimizing file size.

Update logo requirements, include recommendations for optimizing file size.
@sea-snake sea-snake requested a review from a team as a code owner December 4, 2024 12:56
@meodai
Copy link
Contributor

meodai commented Dec 4, 2024

Could you elaborate on why you want to remove WebP? It’s actually the smallest format of the three. If anything, I’d consider removing PNG instead and adding a max file size (KB) requirement to ensure consistency.

That said, keep in mind that not all tools export WebP natively, which might pose challenges for some contributors. Also, SVGs can be tricky since their size depends heavily on the complexity of the logo.

@sea-snake
Copy link
Contributor Author

sea-snake commented Dec 4, 2024

Could you elaborate on why you want to remove WebP? It’s actually the smallest format of the three.

My bad, didn't intend to remove webp, adding it back.

Since it's regarding logos, in most cases SVG would be a smaller file size and also scale when used in various sizes. The raster file formats (png/webp) are there for the few logos that are too complex for a SVG.

@meodai
Copy link
Contributor

meodai commented Dec 4, 2024

@sea-snake I would typically agree but we had a few cases where the SVGs were huge.

My proposal would be:

screenshots: jpeg / webP (specify the PX size and a max KB size maybe max 300?)
logo: webP or svg (50kb max?)

@sea-snake
Copy link
Contributor Author

@sea-snake I would typically agree but we had a few cases where the SVGs were huge.
logo: webP or svg (50kb max?)
50kb is already too much right now with the II canister WASM size limitations, we're aiming for 4kb or less with max 10kb.

I added recommended online tooling for file size optimizations in this PR that saves roughly 70% in most cases, compared to explicit file size limits this seems like a more proactive approach to enable users to keep file sizes optimal.

@meodai
Copy link
Contributor

meodai commented Dec 4, 2024

@sea-snake I don't feel strongly about it. LGTM

@sea-snake sea-snake enabled auto-merge (squash) December 4, 2024 15:09
@sea-snake sea-snake merged commit 0258942 into master Dec 4, 2024
4 checks passed
@sea-snake sea-snake deleted the sea-snake/update-logo-requirements branch December 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants