-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to clean showcase.json #3851
Conversation
I appreciate the effort to streamline the process of cleaning up the showcase, but I think this approach has some issues. Specifically, checking if a site is working or if it uses II based on a single run seems unreliable. Any of these sites could be unreachable for various reasons—temporary downtime, server issues, or even a bad network on the script's end. If we were to proceed with this method, I think it would be more robust to sample these checks over time instead of relying on a one-time test. This way, we could avoid mistakenly flagging legitimate projects as abandoned. Do you know who owns the showcase project? We should talk to whoever this is. |
I agree with you, this script is far from perfect. I hope this is just a first step to help whoever cleans up the showcase @jennifertrin by flagging projects susceptible to be removed. The output of this script should be by no means considered as final. It's a first step to help cleaning up. Ideally, this script will be expanded with the learnings of the manual process and reviewing of the cleaned up projects. That's why I didn't put it in a Github action or anything like that. It's purely a helper for whoever cleans up the showcase. |
Hi @jennifertrin I went one per one of the dapps suggested to be removed:
The script checks the status when making a curl request. This is far from perfect, but it's better than nothing. I can't find a rule that is 100% identifying the abandoned dapps. Some have 4xx status, others 5xx status. Same with the dapps that are not abandoned. For different reasons, they give those statuses. I think that the output of the script should be taken as a starting point of the investigation. Maybe with time it can be fine-tuned by adding a whitelist... This should be owned by whoever cleans up the showcase. ChatGPT is a wonderful companion to help with scripts. I used it for this script, I'm not a bash expert at all. The process is:
I will revert the project that you say are not abandoned for this PR. |
Need more time to think of solution
I also
Hello @lmuntaner, I agree with @meodai that the script is far from perfect; from the first pass, some projects should not have been deleted. However, I do think that we should use it (for now) as you mentioned 1) it has to be manually run 2) the team member running the script still has to open a PR and get it approved. |
4285629
to
9ef4947
Compare
but then why even have it in the repo? Without this context someone might run it... |
The PR still needs to be approved. |
@lmuntaner well looks very merged to me d0158fe |
The PR was approved... what do you mean? |
@lmuntaner 1h ago you said:
|
Ah, I meant from your comment that "someone might run it". Running it doesn't affect the code because the PR with the changes would still need to be approved 😄 |
Motivation
The showcase.json is very long and cleaning up abandoned dapps is painful and a long process.
In this PR, I introduce a script to be run which checks a few things to clean up the showcase:
The changes made by this script should be reviewed by a person.
Changes