-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs audit #3 #3809
Merged
Merged
Docs audit #3 #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0olo
reviewed
Dec 3, 2024
marc0olo
reviewed
Dec 3, 2024
docs/developer-docs/smart-contracts/advanced-features/composite-query.mdx
Outdated
Show resolved
Hide resolved
marc0olo
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, provided 2 small comments
Co-authored-by: Marco Walz <[email protected]>
…e-query.mdx Co-authored-by: Marco Walz <[email protected]>
jessiemongeon1
added a commit
that referenced
this pull request
Dec 3, 2024
* docs audit 1 * docs audit * docs audit * Update install.mdx * Update install.mdx * Update overview.mdx * Update overview.mdx * Update overview.mdx * Update create.mdx * Update compile.mdx * Update create.mdx * Update compile.mdx * Update install.mdx * Update overview.mdx * Update custom-testnets.mdx * Update overview.mdx * Update create.mdx * Update compile.mdx * Update install.mdx * Update overview.mdx * Update custom-testnets.mdx * Update overview.mdx * Update overview.mdx * Dev weekly update Nov 20 2024 * Update compile.mdx * Update create.mdx * Update overview.mdx * Update install.mdx * Update overview.mdx * Update candid-howto.mdx * fix tabs * fix conflicts * fix conflicts * fix conflicts * fix conflicts * revert subs * init * init * fix link * update code snippets * Update docs/developer-docs/smart-contracts/maintain/settings.mdx * Update overview.mdx * Update overview.mdx * Update overview.mdx * Update docs/developer-docs/smart-contracts/write/overview.mdx * Update docs/developer-docs/smart-contracts/write/overview.mdx * Update docs/developer-docs/smart-contracts/write/overview.mdx * Apply suggestions from code review * Update docs/developer-docs/smart-contracts/maintain/history.mdx Co-authored-by: Jennifer K. Tran <[email protected]> * Update docs/developer-docs/smart-contracts/maintain/delete.mdx * Update docs/developer-docs/smart-contracts/maintain/state.mdx Co-authored-by: Jennifer K. Tran <[email protected]> * Update docs/developer-docs/smart-contracts/maintain/state.mdx Co-authored-by: Jennifer K. Tran <[email protected]> * Apply suggestions from code review * Update docs/developer-docs/smart-contracts/maintain/trapping.mdx Co-authored-by: Jennifer K. Tran <[email protected]> * Update docs/developer-docs/smart-contracts/maintain/control.mdx Co-authored-by: Marco Walz <[email protected]> * Apply suggestions from code review Co-authored-by: Marco Walz <[email protected]> * Update docs/developer-docs/smart-contracts/maintain/import.mdx Co-authored-by: Marco Walz <[email protected]> * Update settings.mdx * Docs audit #3 (#3809) * docs audit 3 * Update docs/developer-docs/getting-started/troubleshooting.mdx Co-authored-by: Marco Walz <[email protected]> * Update docs/developer-docs/smart-contracts/advanced-features/composite-query.mdx Co-authored-by: Marco Walz <[email protected]> --------- Co-authored-by: Marco Walz <[email protected]> --------- Co-authored-by: Jennifer K. Tran <[email protected]> Co-authored-by: Marco Walz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdx
file format to support the previous two components./sidebars.js
, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERS
file isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.