Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs audit #3 #3809

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Docs audit #3 #3809

merged 5 commits into from
Dec 3, 2024

Conversation

jessiemongeon1
Copy link
Collaborator

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

@jessiemongeon1 jessiemongeon1 requested a review from a team as a code owner November 22, 2024 23:18
@github-actions github-actions bot added the documentation Changes to Developer Docs label Nov 22, 2024
Copy link
Member

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, provided 2 small comments

@jessiemongeon1 jessiemongeon1 merged commit dcf12f1 into docs-audit-2 Dec 3, 2024
2 of 3 checks passed
@jessiemongeon1 jessiemongeon1 deleted the docs-audit-3 branch December 3, 2024 15:50
jessiemongeon1 added a commit that referenced this pull request Dec 3, 2024
* docs audit 1

* docs audit

* docs audit

* Update install.mdx

* Update install.mdx

* Update overview.mdx

* Update overview.mdx

* Update overview.mdx

* Update create.mdx

* Update compile.mdx

* Update create.mdx

* Update compile.mdx

* Update install.mdx

* Update overview.mdx

* Update custom-testnets.mdx

* Update overview.mdx

* Update create.mdx

* Update compile.mdx

* Update install.mdx

* Update overview.mdx

* Update custom-testnets.mdx

* Update overview.mdx

* Update overview.mdx

* Dev weekly update Nov 20 2024

* Update compile.mdx

* Update create.mdx

* Update overview.mdx

* Update install.mdx

* Update overview.mdx

* Update candid-howto.mdx

* fix tabs

* fix conflicts

* fix conflicts

* fix conflicts

* fix conflicts

* revert subs

* init

* init

* fix link

* update code snippets

* Update docs/developer-docs/smart-contracts/maintain/settings.mdx

* Update overview.mdx

* Update overview.mdx

* Update overview.mdx

* Update docs/developer-docs/smart-contracts/write/overview.mdx

* Update docs/developer-docs/smart-contracts/write/overview.mdx

* Update docs/developer-docs/smart-contracts/write/overview.mdx

* Apply suggestions from code review

* Update docs/developer-docs/smart-contracts/maintain/history.mdx

Co-authored-by: Jennifer K. Tran <[email protected]>

* Update docs/developer-docs/smart-contracts/maintain/delete.mdx

* Update docs/developer-docs/smart-contracts/maintain/state.mdx

Co-authored-by: Jennifer K. Tran <[email protected]>

* Update docs/developer-docs/smart-contracts/maintain/state.mdx

Co-authored-by: Jennifer K. Tran <[email protected]>

* Apply suggestions from code review

* Update docs/developer-docs/smart-contracts/maintain/trapping.mdx

Co-authored-by: Jennifer K. Tran <[email protected]>

* Update docs/developer-docs/smart-contracts/maintain/control.mdx

Co-authored-by: Marco Walz <[email protected]>

* Apply suggestions from code review

Co-authored-by: Marco Walz <[email protected]>

* Update docs/developer-docs/smart-contracts/maintain/import.mdx

Co-authored-by: Marco Walz <[email protected]>

* Update settings.mdx

* Docs audit #3 (#3809)

* docs audit 3

* Update docs/developer-docs/getting-started/troubleshooting.mdx

Co-authored-by: Marco Walz <[email protected]>

* Update docs/developer-docs/smart-contracts/advanced-features/composite-query.mdx

Co-authored-by: Marco Walz <[email protected]>

---------

Co-authored-by: Marco Walz <[email protected]>

---------

Co-authored-by: Jennifer K. Tran <[email protected]>
Co-authored-by: Marco Walz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes to Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants