Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve http response specification in case of errors #3775

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 18, 2024

This PR improves the specification of HTTP responses in case of errors from /api/v2 and /api/v3 APIs.

Closes dfinity/interface-spec#194

@mraszyk mraszyk added the interface-spec Changes to the IC Interface Specification label Nov 18, 2024
@mraszyk mraszyk requested a review from a team as a code owner November 18, 2024 18:25
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this in line with the implementation!

@mraszyk mraszyk merged commit f14ece5 into master Nov 19, 2024
4 checks passed
@mraszyk mraszyk deleted the mraszyk/spec-http-errors branch November 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface-spec Changes to the IC Interface Specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4xx and 5xx responses from query call and read state request
2 participants