feat: asset canister permissions can be set via upgrade args #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaraAS
reviewed
Dec 4, 2023
docs/developer-docs/integrations/sns/managing/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Dec 4, 2023
docs/developer-docs/integrations/sns/managing/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Dec 4, 2023
docs/developer-docs/integrations/sns/launching/launch-steps-1proposal.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Dec 4, 2023
docs/developer-docs/integrations/sns/launching/launch-steps-1proposal.md
Outdated
Show resolved
Hide resolved
…roposal.md Co-authored-by: Lara Schmid <[email protected]>
LaraAS
reviewed
Dec 4, 2023
docs/developer-docs/integrations/sns/launching/launch-summary-1proposal.md
Outdated
Show resolved
Hide resolved
LaraAS
reviewed
Dec 4, 2023
There was a problem hiding this comment.
We could add to Step 7 of both linked launching-pages something like:
"At this point, the SNS canisters exist and the dapp canisters are under SNS DAO control. The initial SNS neurons can use SNS proposals to take the last steps to decentralize the dapp canisters, for example by giving certain permissions to the SNS governance canister stating that these functions can only be triggered by SNS DAO proposal. One example of this is the asset canister (see details [link here])."
jessiemongeon1
approved these changes
Dec 4, 2023
docs/developer-docs/integrations/sns/launching/launch-steps-1proposal.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-steps-1proposal.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/launching/launch-summary-1proposal.md
Outdated
Show resolved
Hide resolved
docs/developer-docs/integrations/sns/managing/sns-asset-canister.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jessie Mongeon <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs changes following up on dfinity/sdk#3443