Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devops): Install dfx in Docker #4374

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(devops): Install dfx in Docker #4374

wants to merge 5 commits into from

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Jan 21, 2025 •
edited
Loading

Motivation

We would like to use dfx inside Docker.

Changes

  • Split the Docker deps stage into parts, so that changes to dfx.json don't cause cache misses.
  • In the first stage, get the dfx version from dfx.json
  • In the last, the builder, install dfx.

Tests

  • The docker build is exercised in CI.

@bitdivine bitdivine marked this pull request as ready for review January 21, 2025 15:40
@bitdivine bitdivine requested a review from a team as a code owner January 21, 2025 15:40
DenysKarmazynDFINITY
DenysKarmazynDFINITY approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@DenysKarmazynDFINITY DenysKarmazynDFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysKarmazynDFINITY DenysKarmazynDFINITY DenysKarmazynDFINITY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitdivine @DenysKarmazynDFINITY