feat(frontend): add ATA creation fee to the Solana send flow #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
requested review from
bitdivine,
peterpeterparker and
DenysKarmazynDFINITY
| }) | ||
| ); | ||
|
|
||
| ataFee = showAtaFee ? await getSolCreateAccountFee(solNetwork) : undefined; |
There was a problem hiding this comment.
Now it can be just ataFee = await getSolCreateAccountFee(solNetwork) 🙂
DenysKarmazynDFINITY
approved these changes
Jan 21, 2025
AntonioVentilii
deleted the
feat(frontend)/add-ATA-creation-fee-to-the-Solana-send-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a Solana address does not have a correspondent Associated Token Account (ATA) for the sending token, OISY will add the instructions to create one. However, this costs money, so it is useful to show it to the user.
Changes
SolFeeDisplayto turn on or off the ATA fee.Tests
The complete flow is:
Screen.Recording.2025-01-20.at.23.29.33.mov