Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontent): updates in progress wizard #4150

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

BonomoAlessandro
Copy link
Collaborator

Motivation

The onDestroy function of the InProgressWizard component is not called every time. To ensure that still every listener is removed and the application is left in a clean state we do have a workaround. When the dirtyWizardState was introduced the workaround function was not updated correctly which sometimes left the application in a weard state. To fix this, the workaround needs to be called every time the $modalStore AND the $dirtyWizardState changes.

Changes

  • updates workaraound cleanup function

@BonomoAlessandro BonomoAlessandro marked this pull request as ready for review January 9, 2025 08:42
@BonomoAlessandro BonomoAlessandro requested a review from a team as a code owner January 9, 2025 08:42
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks

@BonomoAlessandro BonomoAlessandro merged commit 7a61a88 into main Jan 10, 2025
21 checks passed
@BonomoAlessandro BonomoAlessandro deleted the fix(frontend)/fixes-confirmation-modals branch January 10, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants