Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add web-socket to URL validation #4148

Merged
merged 4 commits into from
Jan 9, 2025
Merged

feat(frontend): add web-socket to URL validation #4148

merged 4 commits into from
Jan 9, 2025

Conversation

AntonioVentilii
Copy link
Collaborator

Motivation

Since we will use web socket URLs for Solana subscriptions, it is useful to have URL schema validation include them too.

@AntonioVentilii AntonioVentilii requested a review from a team as a code owner January 9, 2025 08:12
DenysKarmazynDFINITY
DenysKarmazynDFINITY approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@DenysKarmazynDFINITY DenysKarmazynDFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) January 9, 2025 13:24
@AntonioVentilii AntonioVentilii merged commit d629bd9 into main Jan 9, 2025
21 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(frontend)/add-web-socket-to-URL-validation branch January 9, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysKarmazynDFINITY DenysKarmazynDFINITY DenysKarmazynDFINITY approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii @DenysKarmazynDFINITY