feat(frontend): add SolSendReview component #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
requested review from
peterpeterparker and
DenysKarmazynDFINITY
|
|
||
| <svelte:fragment slot="info"> | ||
| {#if insufficientFundsForFee} | ||
| <InsufficientFundsForFee testId="sol-send-form-insufficient-funds-for-fee" /> |
There was a problem hiding this comment.
We'll need to make use of these testIds at some point ;) But I guess I will be doing the same with the Swap feature - merging components first, and coming back to unit tests after the feature is on main just so we can get a security review sooner.
DenysKarmazynDFINITY
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to Bitcoin, we create component
SolSendReview.