fix(frontend): write error log instead of showing an error toast #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the wallet is loaded the application tries to determine if the logged in user is a vip user or not. This displays an error toast if the application is run locally because we do not run the
rewards canisterlocally at the moment. Cause of this the e2e tests fail. As long as we do not run therewards canisterlocally the error toast should not be displayed but an error log should be made.Changes
Tests
before:
oisy-wallet-vip-error-toast-old.mp4
after:
oisy-wallet-vip-error-toast-new.mp4