feature: included ERC20 contract address among the data in tokens.ckerc20.json #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
approved these changes
Jun 20, 2024
AntonioVentilii-DFINITY
deleted the
feature/include-erc20-twin-address-in-ckerc20-json
branch
AntonioVentilii-DFINITY
pushed a commit
that referenced
this pull request
Jun 20, 2024
peterpeterparker
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It will be useful to save the ERC20 contract address of the twin token during the job to create the JSON, for example for PR #1471 .
Changes
erc20_contractand map it.Tests
Running locally, the script worked and there was no disruption in the replica.