Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update banners background #6075

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Update banners background #6075

merged 1 commit into from
Dec 23, 2024
+4 −4

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Dec 23, 2024 •
edited
Loading

Motivation

Update the banner backgrounds to align with the design.

Changes

  • Replace the background variable for the identified banners, using background-color instead of background for improved clarity.

Tests

  • Tested locally:
🌝 🌚
image image
image image
image image

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis requested a review from a team as a code owner December 23, 2024 16:13
yhabib
yhabib approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating the UsdValueBanner 🙌

@mstrasinskis mstrasinskis added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 341bade Dec 23, 2024
31 checks passed
@mstrasinskis mstrasinskis deleted the update-banners-background branch December 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @yhabib