Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Portfolio page with base layout #6062

Merged
merged 3 commits into from
Dec 23, 2024
Merged

feat: implement Portfolio page with base layout #6062

merged 3 commits into from
Dec 23, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Dec 20, 2024

Motivation

The new page for the Portfolio route features a layout with the following sections:

  • Top section
    • TotalAssetsCard: that takes 100% the width when the user is logged in but only 1/3 of the space when the LoginCard is present.
    • LoginCard occupies 2/3 of the space when displayed and appears as the first card on mobile devices.
  • Main section
    • Cards will take up 50% of the available space, and the stack will appear on small screens.
Screen.Recording.2024-12-23.at.16.03.24.mov

Changes

  • New Portfolio page component
  • Renders the new Portfolio page under the Portfolio route
  • Displays the appropriate layout in the (app)/(home)/layout when the feature toggle is on; the Portfolio page is the default page

Tests

  • Unit tests to verify that the LoginCard renders when the user is not logged in.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title WIP: portfolio layout feat: implement portfolio page with base layout Dec 23, 2024
@yhabib yhabib changed the title feat: implement portfolio page with base layout feat: implement Portfolio page with base layout Dec 23, 2024
@yhabib yhabib marked this pull request as ready for review December 23, 2024 15:10
@yhabib yhabib requested a review from a team as a code owner December 23, 2024 15:10
@yhabib yhabib requested a review from mstrasinskis December 23, 2024 15:10
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of optional comments.

frontend/src/lib/pages/Portfolio.svelte Outdated Show resolved Hide resolved
frontend/src/lib/pages/Portfolio.svelte Show resolved Hide resolved
@yhabib yhabib added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 6a9423d Dec 23, 2024
31 checks passed
@yhabib yhabib deleted the nns1-3510/poc branch December 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants