Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger neuron hotkey warning #6061

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Ledger neuron hotkey warning #6061

merged 8 commits into from
Dec 20, 2024

Conversation

mstrasinskis
Copy link
Contributor

Motivation

To prevent missing rewards for ledger neurons, we display a warning on the HW wallet page.

Changes

  • Add LedgerNeuronHotkeyWarning component.
  • Display LedgerNeuronHotkeyWarning .

Tests

  • Added.
  • Tested locally that the banner is closable.
image

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review December 20, 2024 16:20
@mstrasinskis mstrasinskis requested a review from a team as a code owner December 20, 2024 16:20
yhabib
yhabib approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

frontend/src/lib/components/accounts/LedgerNeuronHotkeyWarning.svelte Outdated Show resolved Hide resolved
@mstrasinskis mstrasinskis added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 8e54925 Dec 20, 2024
31 checks passed
@mstrasinskis mstrasinskis deleted the hw-neuron-warning branch December 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabib yhabib yhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @yhabib