Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nav): set AccountsPortfolio as default menu page #6059

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat(nav): set AccountsPortfolio as default menu page #6059

merged 2 commits into from
Dec 20, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Dec 20, 2024 •
edited by jira bot
Loading

Motivation

The new portfolio page will be the default landing page for users in the nns-dapp.
Ticket: NNS1-3510

Changes

  • The home route will render the Portfolio page if the feature flag is enabled.
  • Set route utilities to default to the /portfolio route if there is no match with the current path.

Tests

  • Unit test the behavior of the utils function when ENABLE_PORTFOLIO_PAGE is enabled.
  • Unit test the behavior of the home route when ENABLE_PORTFOLIO_PAGE is enabled.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review December 20, 2024 11:06
@yhabib yhabib requested a review from a team as a code owner December 20, 2024 11:06
@yhabib yhabib requested a review from mstrasinskis December 20, 2024 11:07
@yhabib yhabib added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 37cc835 Dec 20, 2024
31 checks passed
@yhabib yhabib deleted the nns1-3510/home-page-portfolio branch December 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis