Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-next.yml #6050

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Stop installing the latest npm. Because it's not compatible with the current node version.

Changes

  • Commend out install latest npm.

Tests

  • Pass

Todos

  • Add entry to changelog (if necessary).
    Not necessary

Do not install latest npm. Because it's not compatible with the current node version.
@mstrasinskis mstrasinskis marked this pull request as ready for review December 19, 2024 15:05
@mstrasinskis mstrasinskis requested a review from a team as a code owner December 19, 2024 15:05
@yhabib yhabib requested a review from dskloetd December 19, 2024 15:36
@yhabib
Copy link
Contributor

yhabib commented Dec 19, 2024

Adding a bit of context:

  • Our current update actions for the npm packages gix and ic-js are broken. This issue stems from a line that attempts to install the latest version of npm, as seen here: https://github.com/dfinity/nns-dapp/actions/runs/12411288061/job/34648665259#step:5:15.
  • The problem arose because npm@11 was released three days ago: https://github.com/npm/cli/releases/tag/v11.0.0. They state that they do not support node@18, which disrupts our current workflow.
  • We have also identified that both gix and ic-js do not specify the node version. Currently, we rely on GitHub runners and the Ubuntu version, but this approach is somewhat unreliable. We should investigate this in a separate branch.

@dskloetd
Copy link
Contributor

Tests

  • Pass

What does this mean? How is this tested?

@mstrasinskis mstrasinskis marked this pull request as draft December 19, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants