build: svelte v5 #6020
Draft
build: svelte v5 #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
This was referenced Dec 17, 2024
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
# Motivation Since I'm migrating to Svelte v5 (#6020) and aiming for consistent status across our repo, bumping these two libraries align with OISY. # Changes - `npm rm @testing-library/jest-dom @testing-library/svelte && npm i @testing-library/jest-dom @testing-library/svelte -D` Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
# Motivation Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/components/accounts/SelectNetworkDropdown.svelte 62:6 error `<span>` cannot be a child of `<option>`. `<option>` only allows these children: `<#text>`. The browser will 'repair' the HTML (by moving, removing, or inserting elements) which breaks Svelte's assumptions about the structure of your components. https://svelte.dev/e/node_invalid_placement(node_invalid_placement) svelte/valid-compile ``` # Changes - Remove `span` in `option`. Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
) # Motivation Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` 19:5 error Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />` https://svelte.dev/e/element_invalid_self_closing_tag(element_invalid_self_closing_tag) svelte/valid-compile ``` # Changes - e.g. `<div />` -> `<div></div>` Signed-off-by: David Dal Busco <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
# Motivation Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/modals/neurons/SplitNnsNeuronModal.svelte 1:19 error Unrecognized attribute — should be one of `generics`, `lang` or `module`. If this exists for a preprocessor, ensure that the preprocessor removes it https://svelte.dev/e/script_unknown_attribute(script_unknown_attribute) svelte/valid-compile ``` Signed-off-by: David Dal Busco <[email protected]>
yhabib
pushed a commit
that referenced
this pull request
Dec 17, 2024
The periodic confirmation will change the calculation of voting power. To make it transparent to the user, we are updating the description information on the neuron details page. **Note:** The backend now provides two new fields for the neuron: - `potentialVotingPower` (maximum possible value) - `decidingVotingPower` (adjusted based on the neuron's activity). In this PR, we update only the description, not the rendered voting power value. - Add `activityMultiplier` util. - Display voting power description with activity multiplier. - Added. - Tested manually: | Before | After | |--------|--------| | <img width="782" alt="image" src="https://github.com/user-attachments/assets/8b28a710-b4fa-498e-917e-393255d5679f" /> | <img width="740" alt="image" src="https://github.com/user-attachments/assets/dba6755b-74c1-4e53-88c1-ee8b56cb3cbd" /> | - [ ] Add entry to changelog (if necessary). Not necessary. bot: Update IC Cargo Dependencies to release-2024-12-06_03-16-base (#6014) A newer release of the internet computer is available. We want to keep our Cargo dependencies up to date. * Ran `scripts/update-ic-cargo-deps` to update the Cargo.toml dependencies to the latest IC release. * See CI Co-authored-by: gix-bot <[email protected]> Update snsdemo to release-2024-12-11 (#6015) [The automatic update](#6009) had test failure. It appears that the ckBTC checker, which replaces the KYT canister (see dfinity/snsdemo#427 and dfinity/snsdemo#435), has lower fees. 1. Update the snsdemo release. 2. Update the end-to-end test that failed in the automatic update. Updated - [ ] Add entry to changelog (if necessary). not necessary --------- Co-authored-by: gix-bot <[email protected]> Update changelog after release (#6016) A release has been deployed to production. - Changelog - split out the changes included in the release. - Increment the patch version of the nns-dapp. Add stakeInUsd field to TableNeuron (#6017) We want to show USD values in the neurons tables, similar to the tokens table and the projects table. In this PR we just add the USD stake to the `TableNeuron` objects. It will be displayed in future PRs. 1. Add `stakeInUsd` field to `TableNeuron` type. 2. Populate `stakeInUsd` in and `tableNeuronsFromNeuronInfos` and `tableNeuronsFromSnsNeurons`. 3. Make `icpSwapUsdPrices` temporarily an optional parameter until we pass it from all the components callers in future PRs. Then they will be tested too. 1. Unit tests adapted. 2. Tested manually (including future changes) at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/neurons/?u=qsgjb-riaaa-aaaaa-aaaga-cai - [ ] Add entry to changelog (if necessary). not yet refactor: types toast messages (#6012) We want to define the types of potential messages that can be passed to the `toast` store. We can extract this list of potential messages from `I18n`. https://github.com/user-attachments/assets/17c7d582-bf7b-42f4-b873-8aee9c2919a5 We can't enforce just `I18n` keys as we have some places were we programmatically pass the value and we don't have control on the type. - Types `labelKey` based on `I18n` nested keys. - Not necessary - [ ] Add entry to changelog (if necessary). Not necessary Support rendering stake in USD in NeuronsTable (#6018) We want to show USD values in the neurons tables, similar to the tokens table and the projects table. This PR adds support for rendering the `stakeInUsd` field in the `NeuronsTable` components. Still missing (for future PRs): 1. Passing `icpSwapUsdPrices` to `tableNeuronsFromNeuronInfos` and `tableNeuronsFromSnsNeurons`. 2. Calling `loadIcpSwapTickers` on the neurons table page to make sure data is available. 1. Render stake in USD in `NeuronStakeCell.svelte` if `ENABLE_USD_VALUES_FOR_NEURONS` is enabled. 1. Unit tests added. 2. Manually at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/neurons/?u=qsgjb-riaaa-aaaaa-aaaga-cai - [ ] Add entry to changelog (if necessary). not yet feat: filters icp ledger transactions based on range if provided (#5991) Users can select a date range before generating a report. We need to filter the results in the front end and stop fetching pages if we exceed the `from` date. The ledger canister returns transactions sorted by date, with the newest transaction listed first and the oldest transaction listed last. ``` Present Past (now) (t) 0-----------------------[TO]-----------------[FROM]--------------------------->t | | | | | | | | Current time Newer limit Older limit Earliest transaction - Transactions BETWEEN 'from' and 'to' are included - Transactions NEWER than 'from' are excluded - Transactions OLDER than 'to' are excluded ``` - Extends `getAllTransactionsFromAccountAndIdentity` to accept a date range for filtering results and to stop fetching. - Unit tests - [ ] Add entry to changelog (if necessary). Not necessary build: bump testing-library to latest (#6025) Since I'm migrating to Svelte v5 (#6020) and aiming for consistent status across our repo, bumping these two libraries align with OISY. - `npm rm @testing-library/jest-dom @testing-library/svelte && npm i @testing-library/jest-dom @testing-library/svelte -D` Signed-off-by: David Dal Busco <[email protected]> fix: <span> cannot be a child of <option> (#6023) Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/components/accounts/SelectNetworkDropdown.svelte 62:6 error `<span>` cannot be a child of `<option>`. `<option>` only allows these children: `<#text>`. The browser will 'repair' the HTML (by moving, removing, or inserting elements) which breaks Svelte's assumptions about the structure of your components. https://svelte.dev/e/node_invalid_placement(node_invalid_placement) svelte/valid-compile ``` - Remove `span` in `option`. Signed-off-by: David Dal Busco <[email protected]> chore: self-closing HTML tags for non-void elements are ambiguous (#6022) Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` 19:5 error Self-closing HTML tags for non-void elements are ambiguous — use `<div ...></div>` rather than `<div ... />` https://svelte.dev/e/element_invalid_self_closing_tag(element_invalid_self_closing_tag) svelte/valid-compile ``` - e.g. `<div />` -> `<div></div>` Signed-off-by: David Dal Busco <[email protected]> chore: unrecognized attribute xmlns:svelte (#6021) Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/modals/neurons/SplitNnsNeuronModal.svelte 1:19 error Unrecognized attribute — should be one of `generics`, `lang` or `module`. If this exists for a preprocessor, ensure that the preprocessor removes it https://svelte.dev/e/script_unknown_attribute(script_unknown_attribute) svelte/valid-compile ``` Signed-off-by: David Dal Busco <[email protected]> NNS1-3486: adds ReportingDateRangeSelector (#6019) Users can filter their export by choosing one of three options: all, this year, or last year. <img width="793" alt="Screenshot 2024-12-16 at 22 16 48" src="https://github.com/user-attachments/assets/7ff41787-3c66-4d04-81e2-e89b9c9cf2f9" /> A follow up PR will introduce a new component `ReportingDateRangeSelector` that will onrchestrate the `dateRange` filter by passing it down to both, the `ReportingDateRangeSelector` and to `ReportingTransactionsButton`. - Adds a new component called `ReportingDateRangeSelector` to change the value of the date range filter. - Unit tests - [ ] Add entry to changelog (if necessary). Not necessary
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
# Motivation Fix warning which becomes an error with Svelte v5 tooling (PR #6020). ``` /Users/daviddalbusco/projects/dfinity/nns-dapp/frontend/src/lib/components/accounts/CkBTCInfoCard.svelte 85:15 error `<div>` cannot be a descendant of `<p>`. When rendering this component on the server, the resulting HTML will be modified by the browser (by moving, removing, or inserting elements), likely resulting in a `hydration_mismatch` warning https://svelte.dev/e/node_invalid_placement_ssr(node_invalid_placement_ssr) svelte/valid-compile ``` # Changes - Transform container `p` into a `div`. Signed-off-by: David Dal Busco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to stay up-to-date with the tooling for best practices and security reasons.
Changes
Tests
Todos