-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNS1-3435: Reuse ConfirmationModal styles through other consumers of ConfirmationModal #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
commented
Nov 7, 2024
yhabib
commented
Nov 7, 2024
yhabib
changed the title
VoteConfirmationModal reuses styles from ConfirmationModal
NNS1-3435: VoteConfirmationModal reuses styles from ConfirmationModal
Nov 7, 2024
yhabib
changed the title
NNS1-3435: VoteConfirmationModal reuses styles from ConfirmationModal
NNS1-3435: Reuse ConfirmationModal styles through other consumers of ConfirmationModal
Nov 7, 2024
mstrasinskis
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
How come in the screenshot you posted of "Confirm Addition of Hotkey" the last sentence is still centered? |
dskloetd
reviewed
Nov 7, 2024
frontend/src/lib/components/accounts/ImportTokenRemoveConfirmation.svelte
Outdated
Show resolved
Hide resolved
frontend/src/lib/modals/accounts/HardwareWalletNeuronAddHotkeyModal.svelte
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/accounts/ImportTokenRemoveConfirmation.svelte
Show resolved
Hide resolved
yhabib
force-pushed
the
NNS1-3435/unify-confirmation-modal
branch
2 times, most recently
from
November 7, 2024 17:18
bb9b358
to
07f51da
Compare
yhabib
commented
Nov 8, 2024
yhabib
force-pushed
the
NNS1-3435/unify-confirmation-modal
branch
from
November 8, 2024 09:35
5c0fa50
to
7e09e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a common
ConfirmationModal
component that should be reused for many different flows.Changes
ConfirmationModal
and reuses exported css from the confirmation-modal styles.Tests
Testable under https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/
VoteConfirmationModal
Before:
After:
DissolveActionButtonModal
Before:
Title alignment will be fixed generally after this MR.
After:
ImportTokenRemoveConfirmation:
Before:
After:
HardwareWalletNeuronAddHotkeyModal
Before:
After:
Todos
Not necessary.