Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3435: Reuse ConfirmationModal styles through other consumers of ConfirmationModal #5740

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Nov 7, 2024

Motivation

There is a common ConfirmationModal component that should be reused for many different flows.

Changes

  • Removes custom css by consumers of ConfirmationModal and reuses exported css from the confirmation-modal styles.

Tests

Testable under https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/

VoteConfirmationModal

Before:
Screenshot 2024-11-07 at 11 57 28

After:
Screenshot 2024-11-07 at 13 04 25

DissolveActionButtonModal

Before:
Screenshot 2024-11-07 at 13 20 48

Title alignment will be fixed generally after this MR.

After:
Screenshot 2024-11-07 at 13 21 03

ImportTokenRemoveConfirmation:

Before:
Screenshot 2024-11-07 at 13 45 05

After:
Screenshot 2024-11-07 at 13 49 38

HardwareWalletNeuronAddHotkeyModal

Before:
Screenshot 2024-11-07 at 13 55 47

After:
Screenshot 2024-11-08 at 09 47 06

Todos

  • Add entry to changelog (if necessary)
    Not necessary.

@yhabib yhabib marked this pull request as ready for review November 7, 2024 13:43
@yhabib yhabib requested a review from a team as a code owner November 7, 2024 13:43
@yhabib yhabib changed the title VoteConfirmationModal reuses styles from ConfirmationModal NNS1-3435: VoteConfirmationModal reuses styles from ConfirmationModal Nov 7, 2024
@yhabib yhabib changed the title NNS1-3435: VoteConfirmationModal reuses styles from ConfirmationModal NNS1-3435: Reuse ConfirmationModal styles through other consumers of ConfirmationModal Nov 7, 2024
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dskloetd
Copy link
Contributor

dskloetd commented Nov 7, 2024

How come in the screenshot you posted of "Confirm Addition of Hotkey" the last sentence is still centered?

@yhabib yhabib force-pushed the NNS1-3435/unify-confirmation-modal branch 2 times, most recently from bb9b358 to 07f51da Compare November 7, 2024 17:18
@yhabib yhabib force-pushed the NNS1-3435/unify-confirmation-modal branch from 5c0fa50 to 7e09e47 Compare November 8, 2024 09:35
@yhabib yhabib enabled auto-merge November 8, 2024 13:17
@yhabib yhabib added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 2eae81c Nov 8, 2024
30 checks passed
@yhabib yhabib deleted the NNS1-3435/unify-confirmation-modal branch November 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants