Enforces an exact match of replica processes #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
reviewed
Nov 6, 2024
yhabib
added a commit
to dfinity/snsdemo
that referenced
this pull request
Nov 6, 2024
A script runs `pgrep -l replica` to check for replica processes, but it can't receive false positives from a process called `replicatord`. Eg: ```sh $ pgrep -l replica 781 replicatord 95113 replica ``` This change allowed me to run it without issues. I also tried to start a second snapshot, and it correctly informed me that a replica was already running. Related to dfinity/nns-dapp#5732
yhabib
force-pushed
the
fix/snapshot-start-script
branch
from
d890209 to
34063fc
Compare
dskloetd
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A script runs
pgrep -l replicato check for replica processes, but it can't receive false positives from a process calledreplicatord.Changes
replica.Tests
I couldn't run the script that starts the snapshot without this change because it was complaining about a process (
replicatord) matching the pattern. This change allowed me to run it without issues. I also tried to start a second snapshot, and it correctly informed me that a replica was already running.Todos