Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3094: Make projects without neurons clickable again #5216

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dskloetd
Copy link
Contributor

Motivation

In #5202 I made projects without neurons not clickable.
But this makes it not possible to stake those tokens.
We are still working on a way to stake tokens from the projects table but this doesn't need to be part of the MVP.
So we want to make all projects clickable again for now.

Changes

Give every TableProject a rowHref regardless of neurons.

Tests

  1. As we may go back again on this once there is a way to stake from the projects table, I kept the structure of the tests the same but just changed the expectations.
  2. Tested manually at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/staking/

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review July 18, 2024 08:47
@dskloetd dskloetd requested a review from a team as a code owner July 18, 2024 08:47
@dskloetd dskloetd added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit b2e9b40 Jul 18, 2024
39 of 40 checks passed
@dskloetd dskloetd deleted the kloet/yes-href branch July 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants